-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
There were added not that long ago and very welcomed by some developers (including myself). I don’t think it hurts to leave them. Especially |
@hacfi when you use the ParameterHandler to ask you for the parameters when running a I would even say that |
@hacfi note that nothing prevents you to keep these parameters in your own project if you find them handy |
Ok..I’m fine with the removal then. I just thought it’s a feature (enable/disable debug_toolbar) even beginners might want to use early on. |
@@ -42,7 +42,7 @@ monolog: | |||
# level: info | |||
|
|||
assetic: | |||
use_controller: "%use_assetic_controller%" | |||
use_controller: "%kernel.debug%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that this setting impacts the routing definitions and the asset url, it would be better to avoid depending on the debug mode but only on the environment. The cached router is not varying based on the debug flag, so accessing the same environment in debug mode and in non-debug mode could create weird issues if the assetic config is based on it.
It is better to define either true
or false
in config_dev.yaml
rather than %kernel.debug%
In few projects I maintained, I do the following tricks:
Like that:
|
That's a great solution..thanks @lyrixx |
@@ -23,3 +23,6 @@ monolog: | |||
level: debug | |||
console: | |||
type: console | |||
|
|||
assetic: | |||
use_controller: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be avoided as it is already the default
is already defined elsewhere
Now that the "Best Practices" book has been published, another reason for merging this proposal is that it's better aligned with those recommendations. |
👍 |
1 similar comment
👍 |
Thank you @javiereguiluz. |
@fabpot what do you think about my comment related to the database driver ? |
The |
And the changes reverted here were done in #603 exactly to be able to change it per dev. |
And what about |
@Tobion I agree with you about the locale, but I disagree with you for the secret. Because you should avoid to commit "password / secret" in your SCM. |
Also, when you analyze your app with Insight tool, it suggests you to put your |
Originally, the
parameters.yml
was designed to define the infrastructure-related settings (in other words, the settings that may change from one computer to another). Meanwhile, theconfig_*.yml
files are the ones that define the application behavior (in other words, the settings that stay the same from one computer to another).In my opinion, the three removed parameters are related to application behavior and they shouldn't be defined at the
parameters.yml
file.