This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Remove base layout that is not actually used #723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@symfony/deciders ping |
|
On one hand it's kinda useless and I end up replacing it more often than not, but I could also see it as a good thing to nudge everyone in the same direction for block names and such. Not a huge deal either way so I'm +0 I guess :) |
|
I thought it was a good idea to remove this layout because it wasn't used ... but in this other PR that introduces the AppBundle (#728) the layout is now used. So I think now it makes sense to not merge this PR. |
|
I suggest closing this in favor of #728 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This layout file is not actually used in the standard edition.
I don't see why it should be included by default. The standard edition also does not contain other default implementations like controllers for a fast start. So why make an exception for the layout file which is also an objective implementation anyway. And some users of the standard edition probably also don't need an html layout, like an API.