-
-
Notifications
You must be signed in to change notification settings - Fork 356
[Translator] TranslationsDumper builds invalid constant names #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
@jmsche Ah! Didn't consider there could have been a breaking change in the String component. |
Do we need to fix something or is this going to be fixed in next SF release ? |
This has been reverted, let's wait for a new Symfony release |
Thank you for this issue. |
Yes, this is fixed. |
Thank you for this update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the translation sources contain strings instead of identifiers the dumper builds invalid constant names.
results in
Are messages as IDs not supported or is this a bug?
If bug, should the IDs be run through e.g.
AsciiSlugger
?The text was updated successfully, but these errors were encountered: