[Turbo] add options to EventSource Mercure #1774
Conversation
|
But I think the |
|
You have right @tibobaldwin for the first call, but after the Turbo takes over. |
|
But then, how do I add the |
|
Great, this PR is very interesting :). |
|
Sorry @tibobaldwin & @seb-jean, but I think it's not the place for these questions. Check the issue or the documentation? But an example: {% block javascripts %}
<script>
const eventSource = new EventSource("{{ mercure('https://example.com/books/1', { subscribe: ['https://example.com/books/1'] })|escape('js') }}", {
withCredentials: true
});
</script>
{% endblock %}
{% block content %}
<div id="messages" {{ turbo_stream_listen('https://example.com/books/1', eventSourceOptions = {withCredentials: true}) }}
Content
</div>
{% endblock %}Without this PR, you need to create your own turbo stream controller and call like this: ...
{% block content %}
<div id="messages" data-controller="turbo-stream" data-turbo-stream-topic-value="https://example.com/books/1" data-turbo-stream-hub-value="{{ mercure() }}"
Content
</div>
{% endblock %} |
|
Thanks. This is mainly to set the cookie in fact. |
|
Why this isn't merged yet? Seems totally fine to me, and very helpful. |
| */ | ||
| public function renderTurboStreamListen(Environment $env, $topic): string; | ||
| public function renderTurboStreamListen(Environment $env, $topic, array $eventSourceOptions = []): string; |
There was a problem hiding this comment.
You cannot add parameter on an interface, even with default values, without breaking existing implementation.
interface FooInterface
{
public function bar(string $a, array $eventSourceOptions = []): string;
}
class AppFoo implements FooInterface
{
// existing method matching previous interface
public function bar(string $a): string
{
return $a;
}
}This throws a PHP Fatal error as a the concrete implementation is not compatible anymore (see here).
Fatal error: Declaration of AppFoo::bar(string $a): string must be compatible with FooInterface::bar(string $a, array $eventSourceOptions = []): string in php-wasm run script on line 11
So to make this change in a BC way, you need:
- to comment the new argument in the interface
- to use func_get_args to fetch the value in the concrete class
You can see here a recent example of Symfony PR with similar BC layer: symfony/symfony#54531
Poke me if you need a hand here!
|
Indeed closing here as the feature is now implemented |
To prevent 401 with Mercure & Turbo stream on different domain, add an options for EventSource is required.
Exemple of code: