[Translator] Add functional test to ensure only enabled locales are dumped #2946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enabled_locales are dumped
0d1950c to
d0d0163
Compare
|
Failures related on lowest, it looks like the |
enabled_locales are dumpedbf9e6be to
9243d61
Compare
9243d61 to
8cb4384
Compare
Kocal
commented
Jul 27, 2025
| $kernel = new FrameworkAppKernel('test', true); | ||
| $application = new Application($kernel); | ||
|
|
||
| // Trigger Symfony Translator and UX Translator cache warmers |
There was a problem hiding this comment.
I had some issues in lower tests, where our cache warmer was not called when running the functional test.
It worked fine in higher tests thanks to symfony/symfony#57553
But to make it easily consistent, we can manually trigger a cache clear here and the functional test will pass for every Symfony version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1226