[Autocomplete][Chartjs][Cropperjs][Dropzone][Icons][LazyImage][LiveComponent][Map][Notify][React][StimulusBundle][Svelte][Swup][TogglePassword][Toolkit][Translator][Turbo][TwigComponent][Typed][Vue] Add support for Symfony 8#2973
Merged
Merged
Conversation
e7a0922 to
3012a2f
Compare
8b9d4f3 to
240a6ed
Compare
240a6ed to
998de8d
Compare
Kocal
commented
Aug 5, 2025
| "symfony/twig-bundle": "^5.4|^6.0|^7.0", | ||
| "symfony/webpack-encore-bundle": "^1.15" | ||
| "symfony/twig-bundle": "^5.4|^6.0|^7.0|^8.0", | ||
| "symfony/webpack-encore-bundle": "^1.15|^2.3.0" |
Member
Author
There was a problem hiding this comment.
We (dev) require WebpackEncoreBundle to ensure compability with the old AbstractStimulusDto class.
This class does not exist anymore in WebpackEncoreBundle ^2, but upgrading it here allows TwigComponent to be installed with Symfony 8.0, since WebpackEncoreBundle ^1.6 does not support Symfony 8.0.
Member
Author
There was a problem hiding this comment.
The goal is to remove it in UX 3.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in symfony/webpack-encore-bundle#248, I added new jobs for testing explicit Symfony version.
The Symfony 8.0.x-dev job is failing because it needs zenstruck/foundry#891, which is not possible to use because Foundry is not compatible with Symfony 8 yet (opened zenstruck/foundry#960)
There is a lot of changes, but these are only small modifications (composer.json, CHANGELOG.md, and fixing method typings)
I also updated the deprecated packages, that's fine, it makes things easier for us to handle