[LiveComponent] Refactor and fix some edgecases on new URL generation with path + query LiveProps#3053
Merged
Conversation
Kocal
commented
Aug 24, 2025
Kocal
commented
Aug 24, 2025
| } | ||
| } | ||
| $newUrl = $this->router->generate($route, $parameters); | ||
| } catch (ResourceNotFoundException) { |
Member
Author
There was a problem hiding this comment.
I removed the MethodNotAllowedException since I forced the context to GET method
ee72505 to
fffb7a1
Compare
Kocal
commented
Aug 25, 2025
fffb7a1 to
be9c27e
Compare
This was referenced Aug 25, 2025
8d93bd2 to
c9ce9a7
Compare
smnandre
approved these changes
Aug 25, 2025
Member
smnandre
left a comment
There was a problem hiding this comment.
Nice tests additions btw..
… just a tiny doubt on the path thing but ignore them if you are certain it cannot happen :)
And big Thank You
2cb9aed to
18b50c7
Compare
Member
Author
|
I've just applied your comments @smnandre, which indeed fixed a case where a |
…uery LiveProps) generation
18b50c7 to
5c1441f
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #2673
This PR aims to fix the issues #2987, #3015, and #3052, by rewriting the logic to compute the new
X-Live-Urlwhen usingLiveProp()(either with path paremeters or query parameters), inspired by @smnandre's work