[StimulusBundle] Change AssetMapper excluded_patterns from **/controllers.json to */controllers.json#3285
Merged
Conversation
…from `**/controllers.json` to `*/controllers.json` Related to symfony/symfony#61771
excluded_patterns from **/controllers.json to */controllers.jsonexcluded_patterns from **/controllers.json to */controllers.json
Kocal
added a commit
to Kocal/sf-demo
that referenced
this pull request
Jan 10, 2026
Kocal
added a commit
that referenced
this pull request
Jan 10, 2026
Member
Author
|
Missing changelog entry added in 54f68e1 |
Kocal
added a commit
that referenced
this pull request
Jan 11, 2026
# By Hugo Alliaume (7) and others * 2.x: [Toolkit] Prepare base for recipe type "Block" Update root JS dependencies Fix button syntax for file upload actions [Site] Update to Symfony 8 [Site] Update to PHP 8.5 [Site] Update to Symfony 7.4 Add changelog entry for #3285 [StimulusBundle][Performance] Change AssetMapper `excluded_patterns` from `**/controllers.json` to `*/controllers.json` [CI] Fix compatibility issues with Symfony 8 and spatie/phpunit-snapshot-assertions # Conflicts: # pnpm-lock.yaml # src/Map/src/Bridge/Google/assets/dist/map_controller.js # src/Map/src/Bridge/Google/assets/src/map_controller.ts # src/StimulusBundle/CHANGELOG.md # ux.symfony.com/composer.lock
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Jan 16, 2026
… configuration (Kocal) This PR was merged into the main branch. Discussion ---------- Remove double wildcard on AssetMapper `excluded_patterns` configuration Related to symfony/symfony#61771 and symfony/ux#3285 Commits ------- ba4f2f4 Remove double wildcard on AssetMapper `excluded_patterns` configuration
kevinmade
pushed a commit
to kevinmade/ux
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#61771
I wasn't able to run
perfeither (I'm on Mac), but I was still able to see performance improvements.Here is a list of assets from the Symfony Demo, that the AssetMapper should exclude (or not) depending on
exclude_patterns:Given the following patterns:
controllers.json→#^(?=[^\.])controllers\.json$#, the regex does not match directories, let's ignore it,**/controllers.json→^(?=[^\.])/?(?=[^\.]).*.*/(?=[^\.])controllers\.json$: running it on regex101 (withmgflags) costs ~75ms*/controllers.json→#^(?=[^\.]).*/(?=[^\.])controllers\.json$: running it on regex101 (withmgflags) costs ~2ms, ~37.5x less! 🚀And of course, pattern
*/controllers.jsonhas no issue for matching the following path:/Users/kocal/workspace/symfony/symfony-demo/assets/controllers.json/Users/kocal/workspace/symfony/symfony-demo/assets/foo/controllers.json/Users/kocal/workspace/symfony/symfony-demo/assets/foo/bar/controllers.jsonThere is no BC.