Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Autocomplete] Only add the clear_button plugin to TomSelect if the form element is not required #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[Autocomplete] Only add the clear_button plugin to TomSelect if the form element is not required #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Autocomplete/assets/dist/controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class default_1 extends Controller {
_default_1_instances = new WeakSet(), _default_1_getCommonConfig = function _default_1_getCommonConfig() {
const plugins = {};
const isMultiple = !this.selectElement || this.selectElement.multiple;
if (!this.formElement.disabled && !isMultiple) {
if (!this.formElement.required && !this.formElement.disabled && !isMultiple) {
plugins.clear_button = { title: '' };
}
if (isMultiple) {
Expand Down
2 changes: 1 addition & 1 deletion src/Autocomplete/assets/src/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default class extends Controller {

// multiple values excepted if this is NOT A select (i.e. input) or a multiple select
const isMultiple = !this.selectElement || this.selectElement.multiple;
if (!this.formElement.disabled && !isMultiple) {
if (!this.formElement.required && !this.formElement.disabled && !isMultiple) {
plugins.clear_button = { title: '' };
}

Expand Down
10 changes: 10 additions & 0 deletions src/Autocomplete/tests/Fixtures/Form/ProductType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
'autocomplete' => true,
'mapped' => false,
])
->add('colour', ChoiceType::class, [
'choices' => [
'red' => 'red',
'blue' => 'blue',
'green' => 'green',
],
'autocomplete' => true,
'mapped' => false,
'required' => false,
])
->add('tags', TextType::class, [
'mapped' => false,
'autocomplete' => true,
Expand Down
11 changes: 11 additions & 0 deletions src/Autocomplete/tests/Functional/AutocompleteFormRenderingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,21 @@ public function testFieldsRenderWithStimulusController()
->assertElementAttributeContains('#product_category', 'data-symfony--ux-autocomplete--autocomplete-url-value', '/test/autocomplete/category_autocomplete_type?extra_options=')
->assertElementAttributeContains('#product_category', 'data-symfony--ux-autocomplete--autocomplete-min-characters-value', '2')
->assertElementAttributeContains('#product_category', 'data-symfony--ux-autocomplete--autocomplete-max-results-value', '25')
->assertElementAttributeContains('#product_category', 'required', 'required')

->assertElementAttributeContains('#product_ingredients', 'required', 'required')

->assertElementAttributeContains('#product_portionSize', 'data-controller', 'symfony--ux-autocomplete--autocomplete')
->assertElementAttributeContains('#product_portionSize', 'required', 'required')

->assertElementAttributeContains('#product_colour', 'data-controller', 'symfony--ux-autocomplete--autocomplete')
// not implemented in zenstruck/browser
// ->elementAttributeNotExists('#product_colour', 'required')
->assertNotSeeElement('#product_colour[required]')

->assertElementAttributeContains('#product_tags', 'data-controller', 'symfony--ux-autocomplete--autocomplete')
->assertElementAttributeContains('#product_tags', 'data-symfony--ux-autocomplete--autocomplete-tom-select-options-value', 'createOnBlur')
->assertElementAttributeContains('#product_tags', 'required', 'required')
;
}

Expand Down