feat(local): guess project dir based on presence of .symfony.local.yaml #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2024
|
I just ran into an issue where I was testing out a symfony project (specifically the Docker integration with doctrine) and it wasn't working. Turned out it was because I hadn't initiated a .git repo. I was thinking of submitting a PR so that debug mode at the very least tells you it couldn't detect a root directory and to initialize a git repository, but that feels clunky. And what if someone uses Mercurial? I think the idea of detecting a file that is actually Symfony related makes a lot more sense. |
This was referenced Dec 26, 2024
Merged
|
See #555 for an alternative approach. |
|
Thanks for your answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently
symfony-clidoes not discover my project roots anymore - this issue is most obvious in monorepos with different projects. Thus I thought about a different way to discover the project dir.As
symfony-clican read config from.symfony.local.yaml, we should assume the directory containing this config file to be the project directory.