fix url generator signature using the constant for reference type #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ class ContentAwareGeneratorTest extends CmfUnitTestCase | |||
| protected $provider; | |||
|
|
|||
| /** | |||
| * @var ContentAwareGenerator | |||
| * @var TestableContentAwareGenerator | |||
There was a problem hiding this comment.
otherwise the IDE complains that a protected method is used publicly
|
thanks a lot! |
dbu
added a commit
that referenced
this pull request
Oct 20, 2015
fix url generator signature using the constant for reference type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UrlGeneratorInterface::generatemethod uses a "referenceType" instead of "absolute" parameter since symfony version 2.2. The important part is to use the constants as the old values of those are deprecated in 2.8: symfony/symfony#16276I don't know if 1.3 is the correct target branch. If it should be applied somewhere else, please do so.