feat(mismatch-branch-description): be more tolerant about version format #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem, at least this is fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a proposal to make the feature from #207 more tolerant about mistakes when specifying branch in the Symfony's PR template.
E.g when opening symfony/symfony#48451, visually everything was fine but I forgot an HTML comment (which is visually... invisible), which made Carson a bit angry about that :P
Since maintainers look for the HTML-rendered table and not for the Markdown-source table, I think it could be nice to remove HTML comments when checking for the base branch.
WDYT?
Thanks