Autolabel new Pull Requests#29
Closed
javiereguiluz wants to merge 4 commits into
Closed
Conversation
| * @return string The new status | ||
| */ | ||
| public function handlePullRequestCreatedEvent($prNumber) | ||
| public function handlePullRequestCreatedEvent($prNumber, $prTitle, $prBody) |
Contributor
There was a problem hiding this comment.
If we listen to this event, we should also listen for changes to the title/body after the PR was created.
Contributor
Author
There was a problem hiding this comment.
Probably ... but we can leave that enhancement for the future.
Contributor
Author
|
If this feature is finally approved, should we ...
Thanks! |
Contributor
Author
|
Friendly ping to not forget about this PR. What could we do to move it forward? Thanks! |
Contributor
|
@javiereguiluz Tests are missing, overall it looks pretty good 👍 |
Contributor
Author
|
@sstok thanks for the review. I've fixed the failing test. |
Contributor
|
See #34 instead. @javiereguiluz we made such big changes to the repo, it wasn't fair to have you try to figure out the conflict :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two important things:
I haven't tested this in any way and I don't know how to test it in a real repository.
What happens if you try to label an issue with a non-existent label? I guess it will be dropped silently. Otherwise, we'll have a problem if a user creates a PR with a title like this: "[Whatever] Blah blah"FIXED in the latest version of this PR.