Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make behavior of PHP and GitHub references consistent#191

Merged
OskarStark merged 1 commit into
symfony-tools:mainfrom
wouterj:phpclass-consistent
Apr 7, 2025
Merged

Make behavior of PHP and GitHub references consistent#191
OskarStark merged 1 commit into
symfony-tools:mainfrom
wouterj:phpclass-consistent

Conversation

@wouterj
Copy link
Copy Markdown
Contributor

@wouterj wouterj commented Apr 6, 2025

Changes

  • Make escaping consistent for PHP and Github references (require double backslashes, as single can be used to escape the ` character).
  • Add namespace support to :phpmethod: (consistent with :method: and :phpclass:)
  • Update PHP reference text/title to be consistent with GitHub references (e.g. strip the full namespace & only show method name)
  • Use String component in all reference classes

The updates should be fully compatible with Symfony documentation. symfony/symfony-docs#20822 is the only case where we use the new namespace features of :phpclass: (and this revealed the inconsistency).

Copy link
Copy Markdown
Collaborator

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks Wouter.

Comment thread tests/fixtures/expected/blocks/references/php-method.html
@OskarStark OskarStark merged commit 44b5818 into symfony-tools:main Apr 7, 2025
@wouterj wouterj deleted the phpclass-consistent branch April 7, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants