Add preloading info in php.ini #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicolas-grekas
left a comment
There was a problem hiding this comment.
Beware, I think the name changed from 4.4 to 5.1
e39d025 to
e8573bf
Compare
Contributor
Author
|
@nicolas-grekas fixed |
Contributor
|
@localheinz we should add this to our php.ini, too 👌🏻 |
OskarStark
added a commit
to sonata-project/dev-kit
that referenced
this pull request
Sep 3, 2020
This PR * [x] adds an `opcache.preloading` configuration Follows symfonycorp/cloud-templates#15.
1 task
OskarStark
added a commit
to sonata-project/dev-kit
that referenced
this pull request
Sep 3, 2020
This PR * [x] adds an `opcache.preloading` configuration Follows symfonycorp/cloud-templates#15.
Contributor
|
@fabpot it looks like this does not work on SfCloud in combination with Afterwards my logs are showing: Which is correct, it is not in Another option would be todo some "magic" on SfCloud side and replace cc @localheinz |
Contributor
|
We had to remove the setting, we had some strange side effects: and it looks like FPM died: If you need some help to investigate, we can provide a "failing environment" |
Contributor
|
That's for bugs.php.net... |
Contributor
|
About the warnings in your first screenshot @OskarStark, you should investigate them, that's possibly on your side to fix. |
Contributor
|
Will do, thanks |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 7, 2020
…ache.preload predictable (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] generate preload.php in src/ to make opcache.preload predictable | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As seen in symfonycorp/cloud-templates#15, having the path of the preload file vary by env+debug makes configuring PHP.ini settings impossible. This PR dump a new `preload.php` file in `src/` when `cache:clear` is called. This makes the path predictable. This is submitted as a bugfix because the current behavior is barely usable without this change. Commits ------- 54c965c [FrameworkBundle] generate preload.php in src/ to make opcache.preload predictable
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Sep 7, 2020
…ache.preload predictable (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] generate preload.php in src/ to make opcache.preload predictable | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As seen in symfonycorp/cloud-templates#15, having the path of the preload file vary by env+debug makes configuring PHP.ini settings impossible. This PR dump a new `preload.php` file in `src/` when `cache:clear` is called. This makes the path predictable. This is submitted as a bugfix because the current behavior is barely usable without this change. Commits ------- 54c965c7d0 [FrameworkBundle] generate preload.php in src/ to make opcache.preload predictable
Contributor
Author
|
See 1656fdb for an update of the default values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.