Replace vendor patch with custom PhpFileLoader implementation #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d00ade5 to
db3e0a5
Compare
…lve MbConfig loading issue and upgrade dependency packages
db3e0a5 to
c148eac
Compare
|
Why did you remove the ECS and Rector checks from everything? |
Use the main configuration uniformly |
|
Oh, ok. So I may just need to update the main config to check the sub-packages then |
Yes, you are right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace vendor patch mechanism with a custom PhpFileLoader implementation to support MBConfig without modifying
third-party code.
Problem
The project was using cweagans/composer-patches to patch Symfony's PhpFileLoader to support custom configurator
classes (like MBConfig). This approach had several issues:
Solution
Implemented a custom ParameterMergingPhpFileLoader that: