feat(gui): list features together in remote device information (#10376)#10378
feat(gui): list features together in remote device information (#10376)#10378tomasz1986 wants to merge 2 commits intosyncthing:mainfrom
Conversation
|
@imsodin This was originally suggested by you in #9118 (comment), so I would like to ask for your opinion about this implementation. I know that you're not a fan of "disappearing" elements in the GUI, but I tried to combine these with either a "checked" or "unchecked" icon, but it ended up with just too many icons (as the features themselves also have their own icons displayed next to them). |
…hing#10376) Currently, features such as "Introducer", "Auto Accept", and "Untrusted" are all listed in the device information separately with a single-worded "Yes" next to them. With this change, they are all listed together under a single "Features" entry. Ref: syncthing#9118 (comment) Signed-off-by: Tomasz Wilczyński <[email protected]>
908c8c7 to
4b1fa8b
Compare
|
Does it become just |
|
Otherwise I like it. |
Signed-off-by: Tomasz Wilczyński <[email protected]>
Yeah, good catch. Now it will only be shown when at least one of the features is enabled. I have also moved it down just before "Identification". Not sure if there is any particular order here, but I think it may fit better there (after all other information). |
|
NIT: "Untrusted" can hardly be called a "feature". Since those are binary toggles, maybe it'd be better to add separate section right before or after the list, that consists of "tags"? |
feat(gui): list features together in remote device information (#10376)
Currently, features such as "Introducer", "Auto Accept", and "Untrusted"
are all listed in the device information separately with a single-worded
"Yes" next to them. With this change, they are all listed together under
a single "Features" entry.
Ref: #9118 (comment)
Signed-off-by: Tomasz Wilczyński [email protected]
Screenshots
Before
After