feat(gui,config): support simple folder grouping (fixes #2070)#10563
feat(gui,config): support simple folder grouping (fixes #2070)#10563maen-bn wants to merge 3 commits intosyncthing:mainfrom
Conversation
|
Why should this affect the protocol? IMHO folder grouping is a local thing to organize the device's individual folder list. Groups may not mean the same to other users. |
|
This can be even more simple, and can be fully a UI feature with no changes at all. g1/f1 ends up as: g1 g2 etc |
|
That idea has been discussed before on the forum and in some issues, e.g. #2070. The major downside is that it fails for some common labels where a slash is used differently. For example: A separate config field for the grouping was the favored approach IIRC. Heuristics such as separation levels by a slash can be applied there. But mixing semantics with the label field will cause trouble for existing setups. |
No probs. I can drop that. I was just following something you said here about adjusting the protocol but I might have misinterpreted it #2070 (comment) |
This can be fixed by allowing users to mask e.g |
912fe37 to
93aa32a
Compare
Signed-off-by: Ben Norcombe <[email protected]>
Signed-off-by: Ben Norcombe <[email protected]>
93aa32a to
e51b75e
Compare
Really? That still leaves users needing to bend over backwards to adjust their labels, when they simply do not need a grouping feature. Label is a label, completely free form, already used that way. Semantics can be attached to an additional field, with a special purpose.
That was about protobuf, which we had used to define the configuration structure at the time. I believe we went back to simple go structs since. |
|
I would also like to suggest keeping labels their own thing. For example, all my labels are basically relative folder paths (separated with @maen-bn Could you post a screenshot with more folders in each group than just one? I would also be curious how the UI looked if you dropped the group background colour (as I think the current version doesn't look the best, especially with the empty space below the last folder). Alternatively, maybe drop the background for ungrouped folders only? If possible, it would also be nice to see how everything looks in the light and black themes 🙂. |
|
@acolomb Ah okay that makes sense, appreciate the context given I'm a newbie to contributing here. @tomasz1986 there is a part in the gif where two folders are in the same group But I can get a screenshot where there's more than two as well if that helps. Yeah I can remove the background for them and show some screenshots for the light theme too |
Signed-off-by: Ben Norcombe <[email protected]>
|
Here you go @tomasz1986, I've removed the background for the groups and examples of more folders grouped with all the themes available in the GUI Light
Dark
Black
|
|
Thanks for the screenshots! Not sure what others think, but for me, the current iteration (without the background) looks better 🙂. |




Purpose
Adds a very simple way to group up folders to help with organizing from the GUI. My intention is to not make this too complicated and just as a starter but potential follow on PRs to improve this but out of scope here are:
Resolves #2070
Testing
Screenshots
Documentation
I haven't done this yet as I want to wait for the feedback on the changes. I'm happy to do those doc changes too but the changes to the doc should be
Authorship
Ben Norcombe [email protected]