Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Misc #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025
Merged

Misc #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6a929e
Drop -Wno-unused-result flag
cgzones Mar 16, 2025
48537a9
Use NULL as 0 pointer constant
cgzones Mar 16, 2025
547c2cd
Supply comment in static assert
cgzones Mar 16, 2025
e8eccaf
Annotate non NUL-terminated character array
cgzones Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ c_args = '''
-Wwrite-strings
-Wno-unused-parameter
-Wno-missing-field-initializers
-Wno-unused-result
-Werror=overflow
-Werror=sign-compare
-Wdate-time
Expand Down
4 changes: 2 additions & 2 deletions src/netlog/netlog-dtls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,10 @@ int dtls_connect(DTLSManager *m, SocketAddress *address) {
if (cert) {
_cleanup_(OPENSSL_freep) void *subject = NULL, *issuer = NULL;

subject = X509_NAME_oneline(X509_get_subject_name(cert), 0, 0);
subject = X509_NAME_oneline(X509_get_subject_name(cert), NULL, 0);
log_debug("DTLS: Subject: %s", (char *) subject);

issuer = X509_NAME_oneline(X509_get_issuer_name(cert), 0, 0);
issuer = X509_NAME_oneline(X509_get_issuer_name(cert), NULL, 0);
log_debug("DTLS: Issuer: %s", (char *) issuer);
} else
log_debug("DTLS: No certificates.");
Expand Down
2 changes: 1 addition & 1 deletion src/netlog/netlog-ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "netlog-dtls.h"
#include "netlog-tls.h"

static_assert(offsetof(TLSManager, auth_mode) == offsetof(DTLSManager, auth_mode));
static_assert(offsetof(TLSManager, auth_mode) == offsetof(DTLSManager, auth_mode), "TLSManager and DTLSManager must be similar");

/* inspired by SSL_set_verify(3) */
int ssl_verify_certificate_validity(int preverify_ok, X509_STORE_CTX *store) {
Expand Down
4 changes: 2 additions & 2 deletions src/netlog/netlog-tls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,10 @@ int tls_connect(TLSManager *m, SocketAddress *address) {
if (cert) {
_cleanup_(OPENSSL_freep) void *subject = NULL, *issuer = NULL;

subject = X509_NAME_oneline(X509_get_subject_name(cert), 0, 0);
subject = X509_NAME_oneline(X509_get_subject_name(cert), NULL, 0);
log_debug("TLS: SSL Subject: %s", (char *) subject);

issuer = X509_NAME_oneline(X509_get_issuer_name(cert), 0, 0);
issuer = X509_NAME_oneline(X509_get_issuer_name(cert), NULL, 0);
log_debug("TLS: SSL Issuer: %s", (char *) issuer);
} else
log_debug("TLS: SSL No certificates.");
Expand Down
1 change: 1 addition & 0 deletions src/share/hexdecoct.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ int undecchar(char c) {
}

char hexchar(int x) {
__attribute__ ((nonstring))
static const char table[16] = "0123456789abcdef";

return table[x & 15];
Expand Down