Fix an infinite loop during clipping #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice catch, thanks! Have you run the tests after this change? |
Contributor
Author
|
Yup, all tests pass. What happened to travis? |
Contributor
|
No idea, it should have ran the tests against your PR branch, right? |
jazzido
added a commit
that referenced
this pull request
Feb 4, 2016
Fix an infinite loop during clipping
Contributor
Author
|
Yeah, it did last time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue extracting a page where the clipping algorithm would get put into an infinite loop due to some floating point math (because of an infinitesimal difference in points the region code would flip-flop back and forth between LEFT and BOTTOM and keep on calculating).
In cases where the difference between points is essentially 0 I just inserted 0 in place of the difference.