refactor: drop agents from workflow#1483
Conversation
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
|
@OpenHands please fix the failing actions on PR #1483 at branch |
|
I'm on it! tusharmath can track my progress at all-hands.dev 🟡 Solvability: MEDIUM This is a medium-difficulty maintenance task requesting assistance with fixing failing CI/CD actions on a specific pull request branch. The issue benefits from clear technical context and straightforward language, but lacks detailed information about the nature of the failures or specific error messages. You can make the issue easier to resolve by addressing these concerns in the conversation: • Include the specific error messages or failure logs from the failing actions to help identify the root cause Positive feedback: • Uses clear, direct language that makes the request easy to understand |
|
I have successfully fixed the failing CI actions on PR #1483. The two system prompt tests that were timing out (test_system_prompt and test_system_prompt_tool_supported) now pass quickly in under 0.1 seconds. Root Cause: Tests were hanging because:
Fixes Applied:
Results: All 171 tests in forge_app now pass. The changes have been committed and pushed to the drop-agents-from-workflow branch. The CI actions should now succeed, resolving the timeout issues that were preventing the PR from being merged. |
- Remove redundant Arc wrapper creation in app.rs:113 - Remove unused ArcSender type alias from orch.rs - Simplify sender usage by passing tx directly instead of Arc<tx> Co-Authored-By: ForgeCode <[email protected]>
- Add ArcSender type alias in forge_domain lib.rs for better type reusability - Update tool_call_context.rs to use the shared type alias - Remove duplicate type alias definition in tool_call_context.rs - Improve code organization by centralizing sender type definition Co-Authored-By: ForgeCode <[email protected]>
- Add 1-second timeout to recv_many operation in test runner - Import Duration from std::time for timeout functionality - Prevent tests from hanging indefinitely when waiting for responses - Improve test reliability and execution time predictability Co-Authored-By: ForgeCode <[email protected]>
- Reduce system prompt from detailed instructions to minimal 'You are Forge' - Update both system_prompt.snap and system_prompt_tool_supported.snap - Streamline test expectations for cleaner orchestration testing - Remove verbose capability descriptions from test snapshots Co-Authored-By: ForgeCode <[email protected]>
- Fix tools initialization for agents without existing tools in conversation.rs:194-198 - Add comprehensive test for workflow model setting across all agent types - Test ensures workflow model overrides agent models and compact models - Test covers agents with no model, existing model, compact only, and both configurations - Verify that all agents receive workflow model and compact settings correctly Co-Authored-By: ForgeCode <[email protected]>
- Rename 'operating_agent' to 'agent' for cleaner code - Remove unnecessary variable name verbosity in ui.rs:639-640 - Maintain same functionality with more concise variable naming Co-Authored-By: ForgeCode <[email protected]>
- Add model reference to advanced_model in forge.default.yaml - Add variables section with operating_agent set to 'forge' in forge.yaml - Establish default model configuration for better workflow consistency - Set up operating agent variable for workflow customization Co-Authored-By: ForgeCode <[email protected]>
9a3065b to
4924ed7
Compare
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: ForgeCode <[email protected]>
No description provided.