Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: drop agents from workflow#1483

Merged
tusharmath merged 28 commits into
mainfrom
drop-agents-from-workflow
Sep 5, 2025
Merged

refactor: drop agents from workflow#1483
tusharmath merged 28 commits into
mainfrom
drop-agents-from-workflow

Conversation

@tusharmath

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Sep 4, 2025
@tusharmath tusharmath changed the title refactor: update Conversation and Workflow structures to streamline agent handling refactor: move operating agent to app config Sep 4, 2025
@tusharmath tusharmath changed the title refactor: move operating agent to app config refactor: drop agents from workflow Sep 4, 2025
Comment thread crates/forge_domain/src/workflow.rs Outdated
Comment thread crates/forge_domain/src/workflow.rs Outdated
Comment thread crates/forge_domain/src/conversation.rs Outdated
Comment thread crates/forge_domain/src/conversation.rs Outdated
Comment thread crates/forge_app/src/orch_spec/orch_setup.rs Outdated
Comment thread crates/forge_main/src/ui.rs Outdated
Comment thread crates/forge_domain/src/conversation.rs Outdated
Comment thread crates/forge_main/src/state.rs
@openhands-ai

openhands-ai Bot commented Sep 5, 2025

Copy link
Copy Markdown

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • ci

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #1483 at branch `drop-agents-from-workflow`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@tusharmath

Copy link
Copy Markdown
Collaborator Author

@OpenHands please fix the failing actions on PR #1483 at branch drop-agents-from-workflow

@openhands-ai

openhands-ai Bot commented Sep 5, 2025

Copy link
Copy Markdown

I'm on it! tusharmath can track my progress at all-hands.dev

🟡 Solvability: MEDIUM

This is a medium-difficulty maintenance task requesting assistance with fixing failing CI/CD actions on a specific pull request branch. The issue benefits from clear technical context and straightforward language, but lacks detailed information about the nature of the failures or specific error messages.

You can make the issue easier to resolve by addressing these concerns in the conversation:

• Include the specific error messages or failure logs from the failing actions to help identify the root cause
• Provide details about what the actions are supposed to do and at what step they're failing
• Add information about any recent changes made to the workflow or branch that might have caused the failures

Positive feedback:

• Uses clear, direct language that makes the request easy to understand
• Provides specific technical details like the PR number and branch name for context
• Focuses on a single, well-defined component (the failing CI actions) rather than multiple unrelated issues

Comment thread crates/forge_domain/src/conversation.rs Outdated
@CLAassistant

CLAassistant commented Sep 5, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@openhands-ai

openhands-ai Bot commented Sep 5, 2025

Copy link
Copy Markdown

I have successfully fixed the failing CI actions on PR #1483. The two system prompt tests that were timing out (test_system_prompt and test_system_prompt_tool_supported) now pass quickly in under 0.1 seconds.

Root Cause: Tests were hanging because:

  1. Test agents weren't subscribed to handle dispatched events
  2. Mock responses lacked completion tool calls, causing infinite orchestrator loops
  3. Agent name inconsistencies prevented proper event routing

Fixes Applied:

  • Added agent subscriptions (.subscribe() calls) for proper event handling
  • Fixed agent name from "must" to "muse" for consistency
  • Added attempt_completion tool calls to test mocks to prevent infinite loops
  • Updated test snapshots to reflect correct system prompt generation
  • Fixed related test that was using the old agent name

Results: All 171 tests in forge_app now pass. The changes have been committed and pushed to the drop-agents-from-workflow branch. The CI actions should now succeed, resolving the timeout issues that were preventing the PR from being merged.

View full conversation

tusharmath and others added 7 commits September 5, 2025 17:07
- Remove redundant Arc wrapper creation in app.rs:113
- Remove unused ArcSender type alias from orch.rs
- Simplify sender usage by passing tx directly instead of Arc<tx>

Co-Authored-By: ForgeCode <[email protected]>
- Add ArcSender type alias in forge_domain lib.rs for better type reusability
- Update tool_call_context.rs to use the shared type alias
- Remove duplicate type alias definition in tool_call_context.rs
- Improve code organization by centralizing sender type definition

Co-Authored-By: ForgeCode <[email protected]>
- Add 1-second timeout to recv_many operation in test runner
- Import Duration from std::time for timeout functionality
- Prevent tests from hanging indefinitely when waiting for responses
- Improve test reliability and execution time predictability

Co-Authored-By: ForgeCode <[email protected]>
- Reduce system prompt from detailed instructions to minimal 'You are Forge'
- Update both system_prompt.snap and system_prompt_tool_supported.snap
- Streamline test expectations for cleaner orchestration testing
- Remove verbose capability descriptions from test snapshots

Co-Authored-By: ForgeCode <[email protected]>
- Fix tools initialization for agents without existing tools in conversation.rs:194-198
- Add comprehensive test for workflow model setting across all agent types
- Test ensures workflow model overrides agent models and compact models
- Test covers agents with no model, existing model, compact only, and both configurations
- Verify that all agents receive workflow model and compact settings correctly

Co-Authored-By: ForgeCode <[email protected]>
- Rename 'operating_agent' to 'agent' for cleaner code
- Remove unnecessary variable name verbosity in ui.rs:639-640
- Maintain same functionality with more concise variable naming

Co-Authored-By: ForgeCode <[email protected]>
- Add model reference to advanced_model in forge.default.yaml
- Add variables section with operating_agent set to 'forge' in forge.yaml
- Establish default model configuration for better workflow consistency
- Set up operating agent variable for workflow customization

Co-Authored-By: ForgeCode <[email protected]>
@tusharmath tusharmath force-pushed the drop-agents-from-workflow branch from 9a3065b to 4924ed7 Compare September 5, 2025 11:40
@tusharmath tusharmath merged commit 223411a into main Sep 5, 2025
8 checks passed
@tusharmath tusharmath deleted the drop-agents-from-workflow branch September 5, 2025 12:31
laststylebender14 pushed a commit that referenced this pull request Sep 11, 2025
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: ForgeCode <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore Routine tasks like conversions, reorganization, and maintenance work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants