fix: toolcall error count#1562
Merged
Merged
Conversation
tusharmath
commented
Sep 16, 2025
Collaborator
- chore: add ErrorCounter
- chore: add more tests
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Comment on lines
+402
to
+404
| .adjust(&[read], &[]) | ||
| .adjust(&[read], &[]) | ||
| .adjust(&[read], &[]); // Exactly at limit |
Contributor
There was a problem hiding this comment.
Test logic inconsistency with implementation. The test comment says 'Exactly at limit' but calls adjust 4 times for a limit of 3, expecting the tool to be maxed out. However, due to the bug in line 250 using > limit instead of >= limit, this test is actually testing the wrong behavior and masking the boundary condition bug.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.