fix: load usage from conversions when used with cli commands#1575
Merged
tusharmath merged 18 commits intoSep 23, 2025
Merged
Conversation
| .context | ||
| .and_then(|ctx| ctx.usage) | ||
| .unwrap_or(self.state.usage.clone()); | ||
| self.spinner.stop(None)?; |
Contributor
There was a problem hiding this comment.
The spinner.stop() call is placed inside the init_conversation method but only in the None branch (when creating a new conversation). However, the spinner.start() is called at the beginning of this branch. If the conversation_id already exists (Some branch), the spinner is never started, so this placement is correct. But if there's an error between spinner.start() and this spinner.stop(), the spinner will remain running. The spinner.stop() should be moved outside the conversation creation logic or wrapped in proper error handling to ensure it's always called after spinner.start().
Suggested change
| self.spinner.stop(None)?; | |
| let _spinner_guard = self.spinner.guard(); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Base automatically changed from
fix/set-the-usage-from-conversation
to
main
September 17, 2025 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
--resume--conversation