refactor: move model configuration into a JSON file#1650
Merged
Conversation
tusharmath
commented
Oct 4, 2025
Collaborator
- feat: refactor provider handling and add provider configuration from JSON
- fix: standardize provider IDs to lowercase in models.json and update enum serialization
| id: ProviderId::ZaiCoding, | ||
| response: ProviderResponse::OpenAI, | ||
| url: Url::parse(Self::OPEN_ROUTER_URL).unwrap(), | ||
| url: Url::parse("https://api.z.ai/api/coding/v1/").unwrap(), |
Contributor
There was a problem hiding this comment.
There's an inconsistency in the URL paths for the ZAI Coding provider. In the test helper method, the URL is set to https://api.z.ai/api/coding/v1/, but in the models.json configuration file, it's defined as https://api.z.ai/api/coding/paas/v4/.
These URLs should be aligned to ensure consistent behavior between tests and production code. Consider updating one of these values to match the other to prevent potential connection issues.
Suggested change
| url: Url::parse("https://api.z.ai/api/coding/v1/").unwrap(), | |
| url: Url::parse("https://api.z.ai/api/coding/paas/v4/").unwrap(), |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.