fix: order of conversation by updated_at#1662
Merged
Merged
Conversation
tusharmath
commented
Oct 5, 2025
Collaborator
- refactor: replace 'inquire' with 'dialoguer' for improved user prompts
- refactor: replace 'inquire' with 'dialoguer' in dependencies
- refactor: streamline command execution and prompt reset functions
- fix: sort conversations by updated at
updated_at
1c7fdc1 to
dbb393d
Compare
Comment on lines
+118
to
+119
| .filter(conversations::context.is_not_null()) | ||
| .order(conversations::updated_at.desc()) |
Contributor
There was a problem hiding this comment.
The PR title indicates this change is about sorting conversations by updated_at, but the implementation also adds a filter for non-null contexts. This additional filter could potentially exclude conversations that were previously included in the results.
Consider whether:
- The filter is an intentional change that should be mentioned in the PR description
- The filter is necessary for the sorting change to work correctly
- The filter should be removed if it's not part of the intended change
The tests have been updated to include contexts in all test conversations, which suggests this might be intentional, but it would be helpful to clarify the purpose of this additional filter in the PR description.
Suggested change
| .filter(conversations::context.is_not_null()) | |
| .order(conversations::updated_at.desc()) | |
| .order(conversations::updated_at.desc()) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.