fix(domain): ensure workflow model updates agent compaction configurations#818
Merged
Conversation
laststylebender14
pushed a commit
that referenced
this pull request
May 15, 2025
amitksingh1490
pushed a commit
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue with model configuration inheritance in workflows. Previously, when a workflow specified a model, it would update agent models but not properly initialize compaction configurations for agents that didn't have them already. This fix ensures all agents receive consistent model configurations for both regular operation and compaction.
Changes
fix(domain): Ensure workflow models are applied to agent compact configurations
fix(display): Simplify codeblock style initialization in MarkdownFormat