Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle ' syntax in ClojureScript when extracting classes #18888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2025
Merged

Handle ' syntax in ClojureScript when extracting classes #18888

merged 3 commits into from
Sep 5, 2025
+155 −1

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Sep 5, 2025 •
edited
Loading

This PR fixes an issue where the ' syntax in ClojureScript was not handled properly, resulting in missing extracted classes.

This PR now supports the following ClojureScript syntaxes:

; Keyword
(print 'text-red-500)

; List
(print '(flex flex-col underline))

; Vector
(print '[flex flex-col underline])

Test plan

  1. Added regression tests
  2. Verified that we extract classes correctly now in various scenarios:

Top is before, bottom is with this PR:

image

Fixes: #18882

@RobinMalfait RobinMalfait marked this pull request as ready for review September 5, 2025 10:42
@RobinMalfait RobinMalfait requested a review from a team as a code owner September 5, 2025 10:42
@RobinMalfait RobinMalfait merged commit 274be93 into main Sep 5, 2025
7 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-18882 branch September 5, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecrypticace thecrypticace thecrypticace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in extracting classes from symbol list in Clojure
2 participants
@RobinMalfait @thecrypticace