feat: add around shadow which will cover all sides in a component#19213
Closed
mehediScriptDev wants to merge 1 commit intotailwindlabs:mainfrom
Closed
feat: add around shadow which will cover all sides in a component#19213mehediScriptDev wants to merge 1 commit intotailwindlabs:mainfrom
mehediScriptDev wants to merge 1 commit intotailwindlabs:mainfrom
Conversation
Member
|
Hey! I appreciate the PR, but if we want to add shadows like this, we have to do some research to make sure the default shadows make sense and match the current style of the default theme we ship. We would also have to think about the API (naming) and have to create documentation with good examples for this as well. Because of that, I'm going to say no to this PR for now and we can revisit this if there is more demand for native shadows like this. I would recommend to just add these CSS variables to your own projects where you want to use them. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Tailwind team,
I've noticed there isn't an "around-shadow" utility in Tailwind. The existing shadow classes are great, as they only apply shadows to the left, right, and bottom. It feels like the light is coming from the top.
But sometimes we need a shadow for cards or other elements that must cover all sides equally, and there's no built-in class for this.
So, I am proposing a new set of utilities: shadow-around-xs, shadow-around-sm, shadow-around-md, etc.
I am proposing these as an addition, without touching or changing any of the existing shadow properties.