race condition between calling thread and SocketThread #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Thread. It was possible that once the request had been written, the response was coming back before the "this.asyncResult = null" (line 258) statement was being called. This was causing a valid response to be lost and "null" being returned. This fix first checks to ensure no response has been received yet, and only then to wait for a second at most for a response.
Member
|
Thank you very much |
hoegertn
added a commit
that referenced
this pull request
Dec 22, 2015
race condition between calling thread and SocketThread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition between the calling thread and the SocketThread.
It was possible that once the request had been written, the response was coming back before the "this.asyncResult = null" (line 258) statement was being called. This was causing a valid response to be lost and "null" being returned. This fix first checks to ensure no response has been received yet, and only then to wait for a second at most for a response.