Upgrade dependencies and Java (#41) #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis van Beek <[email protected]>
Contributor
|
Does this mean that future versions of the library will have a Java17 dependency? If so this might not be ideal: not everyone is there yet and it might be necessary to maintain multiple versions for this then. |
Contributor
Author
|
@0x08 This indeed is a major change, I would recommend increasing the major version to show this. I don't think 2 versions have to be maintained, because I don't expect a lot of functionality to be added in the coming months (the last release was more than 5 years ago). |
Contributor
|
Maybe Java11 would be a good compromise for now? A version that is widespread and still quite recent. |
Signed-off-by: Dennis van Beek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the dependencies to the latest versions and Java version to Java 17.
Tested it locally (with gpsd-nmea-simulator docker) with the project Tester, and in our own project.
Peer reviewed by my colleague 'mydeveloperplanet'.
Signed-off-by: Dennis van Beek [email protected]