Fix Chokidar watch so Story add or remove is picked up#625
Open
daaain wants to merge 4 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 457c39a The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tajo
reviewed
Dec 15, 2025
| }; | ||
|
|
||
| // Story file pattern - matches .stories.{js,jsx,ts,tsx,mdx} | ||
| export const STORY_FILE_REGEX = /\.stories\.(js|jsx|ts|tsx|mdx)$/; |
Owner
There was a problem hiding this comment.
we should not redefine this here, there is already a default and users can customize it
Author
There was a problem hiding this comment.
Ah, apologies, missed that 😅 just pushed an update to use the given pattern and also realised picomatch can find the base path so removed the custom script to do it
Author
|
@tajo is there anything else I should do on this PR to make it ready to review / merge? The hot reload could make the life of the designer on our team so much better! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #606 that I also ran into.