Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add axes.violinplot test in test_datetime.py #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tanvincible
Copy link
Owner

@tanvincible tanvincible commented Dec 14, 2023

PR summary

This PR is modeled for matplotlib#26864 axes.violinplot.

Points the PR addressed:

  1. Convert Dates to Ordinals:

    Because while doing statistics on dates can get strange fast... saying 'I want a violin plot comparing measurements taken on different dates' seems completely reasonable.

    Code Response: The code converts the datetime values to ordinal values (date.toordinal()) to make them compatible with the violinplot.

  2. Test Positions Instead of Stats Axis:

    I am now curious if at least the positioning values (position and width) work as desired (with the latter being a timedelta).

    Code Response: The code focuses on testing positions (positions=date_ordinals) rather than the stats axis.

  3. Deprioritize Fixing Units Along Stats Axis:

    My leaning is to deprioritize fixing units along the stats axis... ask that this test case is written to focus on positions instead for the time being.

    Code Response: The code doesn't explicitly address the unit conversion for statistics but prioritizes testing positions.

@tanvincible tanvincible deleted the TanviPooranmal-patch-1 branch December 20, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant