Add axes.violinplot test in test_datetime.py #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR is modeled for matplotlib#26864
axes.violinplot
.Points the PR addressed:
Convert Dates to Ordinals:
Code Response: The code converts the datetime values to ordinal values (
date.toordinal()
) to make them compatible with theviolinplot
.Test Positions Instead of Stats Axis:
Code Response: The code focuses on testing positions (
positions=date_ordinals
) rather than the stats axis.Deprioritize Fixing Units Along Stats Axis:
Code Response: The code doesn't explicitly address the unit conversion for statistics but prioritizes testing positions.