Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

thakkarujas5
Copy link
Contributor

Fixes #7197

@thakkarujas5 thakkarujas5 requested a review from a team as a code owner April 5, 2025 20:51
@thakkarujas5 thakkarujas5 requested review from lotas, petemoore and matt-boris and removed request for a team April 5, 2025 20:51
@thakkarujas5 thakkarujas5 changed the title Add logs to task failue email Add logs to task failure email Apr 5, 2025
@thakkarujas5 thakkarujas5 marked this pull request as draft April 5, 2025 20:51
@thakkarujas5 thakkarujas5 force-pushed the feat/notify-fail-email branch from 848f960 to 315242c Compare April 5, 2025 20:53
// Load task definition
let taskId = status.taskId;
let task = await this.queue.task(taskId);
let artifact = await this.queue.latestArtifact(taskId, 'public/logs/live.log');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some installs, access to this log may be restricted, and it may contain sensitive information. So a few concerns here;

  • Check that this.queue has the correct credentials to represent a world-readable (e.g., email) view of the logs
  • If not, fail gracefully
  • Perhaps allow this to be disabled for a deployment, even if the log is "public" in terms of TC scopes (e.g., if the deployment is behind a firewall that would otherwise prevent the email recipients from reading the log)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On task failure notifications could include extra details
2 participants