taskcluster · pinakiz · Aug 27, 2025 · Aug 27, 2025 · Aug 28, 2025 · Sep 1, 2025
diff --git a/changelog/issue-7776.md b/changelog/issue-7776.md
@@ -0,0 +1,5 @@
+audience: developers
+level: patch
+reference: issue 7776
+---
+Fixed schema to allow `.` in GitHub repository names.
diff --git a/clients/client-go/tcgithub/types.go b/clients/client-go/tcgithub/types.go
diff --git a/clients/client-go/tcgithubevents/types.go b/clients/client-go/tcgithubevents/types.go
diff --git a/generated/references.json b/generated/references.json
@@ -3,8 +3,10 @@
 # all common identifiers. It's not personal, it's just that without these
 # limitation, the identifiers won't be useful as routing keys in RabbitMQ
 # topic exchanges. Specifically, the length limitation and the fact that
-# identifiers can't contain dots `.` is critical.
-github-identifier-pattern:     "^([a-zA-Z0-9-_%]*)$"
+# GitHub service automatically sanitizes identifiers by replacing any dots `.` with another
+# character, so dots are allowed but transformed.
+
+github-identifier-pattern:     "^([a-zA-Z0-9-_.%]*)$"
 github-identifier-min-length:  1
 github-identifier-max-length:  100
 github-guid-pattern: "^[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}$"

@@ -0,0 +1,75 @@
+import helper from './helper.js';
+import assert from 'assert';
+import fs from 'fs';
+import yaml from 'js-yaml';
+
+helper.secrets.mockSuite('github-identifier-pattern', [], function(mock, skipping) {
+  suiteSetup(async function() {
+    if (skipping()) return;
+    const constantsYaml = fs.readFileSync('../schemas/constants.yml', 'utf8');
+    const constants = yaml.load(constantsYaml);
+
+    this.githubPattern = new RegExp(constants['github-identifier-pattern']);
+    this.minLength = constants['github-identifier-min-length'];
+    this.maxLength = constants['github-identifier-max-length'];
+  });
+
+  function testLengthConstraints(id) {
+    assert.ok(id.length >= this.minLength, `"${id}" is shorter than min length`);
+    assert.ok(id.length <= this.maxLength, `"${id}" is longer than max length`);
+  }
+
+  test('valid GitHub identifiers', function() {
+    const validIdentifiers = [
+      'abc123',
+      'org-name',
+      'my_repo',
+      'repo123',
+      'ORG-Repo',
+      'abc.def',
+      'name_with_underscores',
+      'name%repo',
+      'percent%encoded',
+      'a',
+      'a'.repeat(100),
+    ];
+
+    validIdentifiers.forEach(id => {
+      assert.ok(this.githubPattern.test(id), `Expected "${id}" to match github-identifier-pattern`);
+      testLengthConstraints.call(this, id);
+    });
+  });
+
+  test('invalid GitHub identifiers', function() {
+    const invalidIdentifiers = [
+      'with space',
+      'repo!',
+      'abc$123',
+      '@org/repo',
+      'org/repo',
+      'org//repo',
+      'repo#1',
+      '😀emoji',
+      'a'.repeat(101),
+    ];
+
+    invalidIdentifiers.forEach(id => {
+      const matchesPattern = this.githubPattern.test(id);
+      const exceedsLength = id.length > this.maxLength;
+      assert.ok(!matchesPattern || exceedsLength, `Expected "${id}" to be invalid`);
+    });
+  });
+
+  test('edge cases for GitHub identifiers', function() {
+    const edgeCases = [
+      'a-b_c',
+      'repo-underscore_only_',
+      'repo-dash-only-',
+      'abc.def%ghi',
+    ];
+    edgeCases.forEach(id => {
+      assert.ok(this.githubPattern.test(id), `Expected "${id}" to match github-identifier-pattern`);
+      testLengthConstraints.call(this, id);
+    });
+  });
+});