Commit Message: Fix variable naming conflict and update header depend… #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encies Description: - Renamed the variable `signals` to `sigs` because `signals` is a keyword in the Qt signal-slot mechanism, which causes compilation errors in a Qt environment. The abbreviation `sigs` is used as a replacement to avoid conflicts. - Used the macro `TF_CACHELINE_SIZE` in the file `nonblocking_notifier.hpp`, which defines the cache line size for optimizing memory alignment and performance. - Added the header file `#include "../utility/os.hpp"` to provide operating system-related utility support, such as platform-specific definitions for cache line size. Changed Files: - `taskflow/core/nonblocking_notifier.hpp`
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…encies
Description:
signalstosigsbecausesignalsis a keyword in the Qt signal-slot mechanism, which causes compilation errors in a Qt environment. The abbreviationsigsis used as a replacement to avoid conflicts.TF_CACHELINE_SIZEin the filenonblocking_notifier.hpp, which defines the cache line size for optimizing memory alignment and performance.#include "../utility/os.hpp"to provide operating system-related utility support, such as platform-specific definitions for cache line size.Changed Files:
taskflow/core/nonblocking_notifier.hpp