feat!: upgrade node and rewrite approach #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Drop support for non-LTS Node.js versions and upgrade the typescript version to support the newer JS features.
7b4670f to
727240a
Compare
BREAKING CHANGE: Replace `connectionStringParser()` with `parse()` method. Rename `buildConnectionString()` to `build()`. Remove `parseSqlConnectionString` and replace with a way to transform parsed connection strings into a specific object schema (see ConnectionString.toSchema()`).
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a rethink of the approach to the interface exposed by this library.
It now parses the connection string and returns a
ReadonlyMap, properties can be accessed usingget()andhas()and it is for the consumer to dictate the type coercion when fetching the value, allowing for more generic and declarative access to props.Also included is a way to get the original connection string value back using
toString()and also to create an arbitrary schema withtoSchema().Todo: