connect callback could miss err argument
#1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback passed to `Connection.prototype.connect` could in some error cases be called without an error argument.
Contributor
|
🎉 This PR is included in version 9.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
arthurschreiber
added a commit
that referenced
this pull request
Dec 21, 2020
Merge pull request #1145 from tediousjs/arthur/fix-connect-errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback passed to
Connection.prototype.connectcould in some error cases be called without an error argument.This issue was introduced in #1102.