Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Gitea Manifest for Git Resolver test #9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Gitea Manifest for Git Resolver test #9007

wants to merge 2 commits into from

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Sep 2, 2025

Gitea pod isn't coming up. This updates gitea to latest version available to avoid this issue.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 2, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 2, 2025
khrm
khrm commented Sep 2, 2025
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 2, 2025
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2025
@khrm khrm force-pushed the gitea-e2e branch 10 times, most recently from 9fcbdad to 00153c4 Compare September 2, 2025 19:08
@waveywaves
Copy link
Member

/retest

@khrm khrm force-pushed the gitea-e2e branch 2 times, most recently from 18a972e to 0e89f70 Compare September 3, 2025 08:57
khrm added 2 commits September 3, 2025 14:39
@khrm
Update Gitea Manifest for Git Resolver test
7eed707 
Gitea pod isn't coming up. This updates gitea to latest
version available to avoid this issue.
Also change the test to get pod name using selector because
gitea uses deployment instead of statefulset.
@khrm
Ignore gitea.yaml for lint test
49279b2 
This file is generated using helm and used during testing. Added it
to ignore.
@vdemeester
Copy link
Member

/retest

@pritidesai
Copy link
Member

This PR is failing with:

        {"id":2,"login":"tekton-bot","login_name":"tekton-bot","source_id":0,"full_name":"tekton-bot","email":"[email protected]","avatar_url":"http://git.example.com/avatars/6fe475c3a78a4ab307dda8f2f0cbab8f","html_url":"http://git.example.com/tekton-bot","language":"","is_admin":true,"last_login":"1970-01-01T00:00:00Z","created":"2025-09-03T16:04:10Z","restricted":false,"active":true,"prohibit_login":false,"location":"","website":"","description":"","visibility":"public","followers_count":0,"following_count":0,"starred_repos_count":0,"username":"tekton-bot"}
          % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                         Dload  Upload   Total   Spent    Left  Speed
        
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   113  100    88  100    25   3267    928 --:--:-- --:--:-- --:--:--  4346
        
        >>> Pod git-resolver-setup-gitea-user-jjelytdd-pod Container sidecar-tekton-log-results:
        {"name":"token","value":"{\"message\":\"access token must have a scope\",\"url\":\"[http://git.example.com/api/swagger\](http://git.example.com/api/swagger/)"}","type":"task"}
    panic.go:636: Not deleting namespace arendelle-b8rvz
--- FAIL: TestGitResolver_API (37.62s)

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2025
@tekton-robot
Copy link
Collaborator

@khrm: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chmouel
chmouel reviewed Sep 4, 2025
View reviewed changes
test/resolvers_test.go
// setting up of cache and db.
time.Sleep(5 * time.Second)
if err := WaitForPodState(ctx, c, "gitea-0", namespace, func(r *corev1.Pod) (bool, error) {
labelSelector := "app.kubernetes.io/name=gitea,app.kubernetes.io/instance=gitea"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about dropping all of that and just use a shell script instead ? ie with installing forgejo with helm https://github.com/chmouel/startpaac/tree/main/lib/forgejo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it makes sense. That's why this issue cropped. We generate template from helm chart using helm and that template got outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer Awaiting requested review from abayer

@pritidesai pritidesai Awaiting requested review from pritidesai

1 more reviewer

@chmouel chmouel chmouel left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@khrm @tekton-robot @waveywaves @vdemeester @pritidesai @chmouel