[FIX] Make download progress bar display correct units#63
Merged
oesteban merged 1 commit intotemplateflow:masterfrom Oct 19, 2020
Merged
[FIX] Make download progress bar display correct units#63oesteban merged 1 commit intotemplateflow:masterfrom
oesteban merged 1 commit intotemplateflow:masterfrom
Conversation
Member
|
I'm going to break master by merging this, but that should be easily solvable if we do this -> nipreps/sdcflows@fef4ac6 Thanks much for this contribution!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading files, the progress display shows file sizes on the order of kilobytes, even though the requested file should be multiple megabytes in size. When I first encountered this, I thought the files may be corrupt, but this is not the case.
Steps to reproduce this
Looking at the code, I discovered that the progress bar module
tqdmis configured to display one download block as one byte, even though one download block can be up to 1024 bytes in size.With the proposed fix, the correct file size is displayed