activity: support batch operations in reset and update-options #831
Conversation
go.mod
Outdated
| go.temporal.io/sdk/contrib/envconfig v0.1.0 | ||
| go.temporal.io/server v1.28.0 | ||
| google.golang.org/grpc v1.71.0 | ||
| go.temporal.io/server v1.29.0-135.0.0.20250718192231-215876cb9fec |
There was a problem hiding this comment.
Cannot merge with untagged server/API. Also, if the tag is not a server OSS release, this PR should go to next-server branch instead.
cretz
left a comment
There was a problem hiding this comment.
LGTM, nothing blocking. Will approve if/when server and API dependencies are on tags (but doesn't have to be server OSS release since it's going to next-server not main).
bergundy
left a comment
There was a problem hiding this comment.
Only reviewed the commands yaml not the implementation. Had some comments.
There was a problem hiding this comment.
Nothing blocking, but would like this PR to not include things added in main since last next-server merge (i.e. need a main merge into next-server outside of this PR IMO or this branch needs to be based off the next-server branch head instead of main head bringing in extra things).
|
Please make sure you don't merge all of |
…#824) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> `temporal activity {pause,unpause,reset}` commands take either an `--activity-id` or `activity-type` argument but not both. If both are provided the command will fail We want to fail when both are provided, the user doesn't need to provide activity type and id as type can be inferred from type. <!--- add/delete as needed ---> 1. Closes no issue 2. How was this tested: * new unit test showing failure 3. Any docs updates needed? documentation updates will be needed, @drewhoskins-temporal or @ychebotarev can share where and I will update
0903823 to
23ee272
Compare
| return nil, fmt.Errorf("root command unexpectedly missing when dialing client") | ||
| } | ||
|
|
||
| if c.Identity == "" { |
There was a problem hiding this comment.
I wonder why this is in your PR, it seems unrelated.
There was a problem hiding this comment.
See #831 (comment). I think the issue is we apparently have a need for an --identity arg for all client uses not just this one, so it was added. So this code changed from clientOptions.Identity = clientIdentity() to clientOptions.Identity = <user-provided-or-default> and the clientIdentity() helper was removed since people should rely on the options value.
bergundy
left a comment
There was a problem hiding this comment.
Please see my suggestions and apply to the reset command as well.
* The `temporal activity {pause,update-options}` support batch
operations through `--query`
* Consistently passing the `--identity` parameter to server requests
Improved developer experience, can batch these requests through a
visibility query instead of sending multiple requests
2. How was this tested:
New unit tests
3. Any docs updates needed?
Documentation updates are automatically generated with releases.
* The `temporal activity {pause,update-options}` support batch
operations through `--query`
* Consistently passing the `--identity` parameter to server requests
Improved developer experience, can batch these requests through a
visibility query instead of sending multiple requests
2. How was this tested:
New unit tests
3. Any docs updates needed?
Documentation updates are automatically generated with releases.
What was changed
temporal activity {pause,update-options}support batch operations through--query--identityparameter to server requestsWhy?
Improved developer experience, can batch these requests through a visibility query instead of sending multiple requests
Checklist
Closes: N/A
How was this tested:
New unit tests
Any docs updates needed?
Documentation updates are automatically generated with releases.