Porting to Python, Java Polling Examples #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Apr 13, 2023
|
@rachfop - let me know when ready for another review |
rachfop
commented
Apr 18, 2023
rachfop
commented
Apr 18, 2023
rachfop
commented
Apr 18, 2023
Ready 😎 |
cretz
reviewed
Apr 18, 2023
cretz
reviewed
Apr 19, 2023
|
|
||
|
|
||
| @activity.defn | ||
| async def compose_greeting(input: ComposeGreetingInput) -> str: |
There was a problem hiding this comment.
Why does this one not loop like the Go and Java ones do?
cretz
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adds Python examples for polling.
Why?
Java and GoLang have these examples.
Based on this thread.
Checklist
Closes
How was this tested:
Ran
poe format&&poe lintObserved the Workflow History.