Add support for start delay to the time skipping test server #2462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dccf8b0 to
e5cf6b7
Compare
cretz
approved these changes
Mar 31, 2025
Comment on lines
60
to
64
| long start = testWorkflowRule.getTestEnvironment().currentTimeMillis(); | ||
| stubF.func(); | ||
| long end = testWorkflowRule.getTestEnvironment().currentTimeMillis(); | ||
| // Assert that the workflow took at least 5 seconds to start | ||
| assertEquals(5000, end - start, 1000); |
There was a problem hiding this comment.
Can you confirm just in this comment thread that if time skipping is not enabled/uinlocked, this waits the actual system amount of time? Understood if not practical to write such a test.
There was a problem hiding this comment.
Yeah, that was what this test was supposed to do, but I shouldn't have used the test environments time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for start delay to the time skipping test server.
closes #1692