Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Support WorkflowImplementationOptionsCustomizer so users can customize workflow implementation options per type in Springboot

closes #1984

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner May 2, 2025 18:09
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we had thought about this holistically with dynamic workflow versioning, we'd have one solution to customize workflow implementation options at runtime. As of now there is one way for spring, one way for dynamic workflows for only one option, and no way for non-spring, non-dynamic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to runtime customization

This is for customizing workflow implementation options per workflow type at registration time, the Java SDK already supports this, this is just aligning spring boot with the regular Java SDK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring is not getting any special functionality

Copy link
Member

@cretz cretz May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there could be an overlap to "customize options by workflow type" whether that workflow type is known at registration time or runtime (though runtime obviously gives you more info than workflow type, so not that much overlap).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the point is this PR adds registration time customization for Spring which we already have for the Java SDK

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 0d539ff into temporalio:master May 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Temporal Spring-boot Starter] customizing workflow options by workflow type
2 participants