Wire reason parameter in workflow cancellation request #2519
Conversation
There was a problem hiding this comment.
How does this relate to #2414 (as part of temporalio/features#596)? Specifically, is this a partial implementation of that? And are other SDKs expected to follow suit with a "reason" from client side?
There was a problem hiding this comment.
Yes as I said in the PR description this does not cover the workflow side
There was a problem hiding this comment.
👍 Just wanted to confirm it is part of that project since it wasn't linked
There was a problem hiding this comment.
reason on the client side is something we already do for terminate. I think how we expose this on the workflow side needs a bit of SDK team consensus so I left it out for now.
There was a problem hiding this comment.
Does this apply to child workflows?
There was a problem hiding this comment.
This is the client WorkflowStub, child workflows have a different stub interface.
There was a problem hiding this comment.
👍 I see CancellationScope.cancel accepts a reason, does that propagate to RequestCancelExternalWorkflowExecutionCommandAttributes.reason proto for child workflow? Similarly, I think we may want to have an overload for ExternalWorkflowStub.cancel that accepts reason. Both of those can be separate issues though, not blocking this one.
There was a problem hiding this comment.
I see CancellationScope.cancel accepts a reason, does that propagate to RequestCancelExternalWorkflowExecutionCommandAttributes.reason proto for child workflow?
Not currently, the whole workflow side still needs to be done
1b8d3a2 to
e63d36e
Compare
Wire reason parameter in workflow cancellation request. Not this does not cover wiring the cancellation reason on the workflow side. There is a different issue to track that work.
closes #1350