Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix using wrong config option for resource controller #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

Fix using wrong config option for resource controller #2607

merged 2 commits into from
Aug 1, 2025

Conversation

vanhtuan0409
Copy link
Contributor

@vanhtuan0409 vanhtuan0409 commented Jul 30, 2025 •
edited
Loading

What was changed

Correct PID controller config for Memory usage. Currently, pid controller for memory is using the config from CPU options

Why?

Resource base tuner currently running with wrong configuration

Checklist

  1. Closes

  2. How was this tested: Compile test

  1. Any docs updates needed? No

@vanhtuan0409 vanhtuan0409 requested a review from a team as a code owner July 30, 2025 08:52
Sushisource
Sushisource approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Pretty sad little mistake.

@Sushisource Sushisource merged commit 26546a7 into temporalio:master Aug 1, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanhtuan0409 @Sushisource