Add namespace to requests where it was missing #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeybykov
requested changes
Dec 14, 2020
Member
sergeybykov
left a comment
There was a problem hiding this comment.
Need to also set namespace at
...oral-sdk/src/main/java/io/temporal/internal/external/ManualActivityCompletionClientImpl.java
Outdated
Show resolved
Hide resolved
Member
|
Need to also set namespace at |
sergeybykov
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to this PR in go SDK, we are populating namespace field where it was missing.
Related proto changes in the API repo are #101 and #102.