-
Notifications
You must be signed in to change notification settings - Fork 97
Search attribute Datetime need to support full ISO 8601 (and maybe more) #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
From https://docs.python.org/3/library/datetime.html#datetime.datetime.fromisoformat:
|
I've been experimenting with the new Scheduler system released in Temporal
This produces the following stack trace:
I did some work on a fork that resolved down to a one-line fix + some unit tests for regression testing around the I'll open a PR with the fix now, hopefully the problem is as simple as it appears |
👍 Saw the PR but wondering if we can avoid the additional dependency. Are there any snippets/approaches where we could do this using just the standard library? (EDIT: Starting to look unreasonable to vendor this or avoid the dependency. I'll update the PR) |
Describe the bug
2022-09-27T22:28:42Z
cannot be parsed bydatetime.fromisoformat
which we are using for search attributes. Make sure the full RFC3339Nano is supported.The text was updated successfully, but these errors were encountered: