Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug] Returning given payload object in codec causes issues #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cretz opened this issue May 9, 2024 · 0 comments · Fixed by #526
Closed

[Bug] Returning given payload object in codec causes issues #525

cretz opened this issue May 9, 2024 · 0 comments · Fixed by #526
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented May 9, 2024

Describe the bug

If a codec returns the same payload object it was given on decode, it can cause issues due to a bug with how we update the original payload
@cretz cretz added the bug Something isn't working label May 9, 2024
cretz added a commit to cretz/temporal-sdk-python that referenced this issue May 9, 2024
@cretz
Fix issue with codecs returning passed-in payloads
61a0298 
Fixes temporalio#525
@cretz cretz mentioned this issue May 9, 2024
Merged
@cretz cretz closed this as completed in #526 May 9, 2024
cretz added a commit that referenced this issue May 9, 2024
@cretz
Fix issue with codecs returning passed-in payloads (#526)
f96679b 
Fixes #525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with codecs returning passed-in payloads cretz/temporal-sdk-python
1 participant
@cretz