Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug] Update requests should set first_execution_run_id #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dandavison opened this issue Nov 1, 2024 · 0 comments
Closed

[Bug] Update requests should set first_execution_run_id #682

dandavison opened this issue Nov 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dandavison
Copy link
Contributor

dandavison commented Nov 1, 2024 •
edited
Loading

Update requests do not send first_execution_run_id:

sdk-python/temporalio/client.py

Lines 5252 to 5285 in 0b327b0

async def start_workflow_update(
self, input: StartWorkflowUpdateInput
) -> WorkflowUpdateHandle[Any]:
# Build request
req = temporalio.api.workflowservice.v1.UpdateWorkflowExecutionRequest(
namespace=self._client.namespace,
workflow_execution=temporalio.api.common.v1.WorkflowExecution(
workflow_id=input.id,
run_id=input.run_id or "",
),
request=temporalio.api.update.v1.Request(
meta=temporalio.api.update.v1.Meta(
update_id=input.update_id or str(uuid.uuid4()),
identity=self._client.identity,
),
input=temporalio.api.update.v1.Input(
name=input.update,
),
),
wait_policy=temporalio.api.update.v1.WaitPolicy(
lifecycle_stage=temporalio.api.enums.v1.UpdateWorkflowExecutionLifecycleStage.ValueType(
input.wait_for_stage
)
),
)
if input.args:
req.request.input.args.payloads.extend(
await self._client.data_converter.encode(input.args)
)
if input.headers is not None:
temporalio.common._apply_headers(
input.headers, req.request.input.header.fields
)

However, they should, and other SDKs do.

Also, is it correct that we don't use the run ID from the response when constructing the returned update handle?
@dandavison dandavison added the bug Something isn't working label Nov 1, 2024
dandavison added a commit that referenced this issue Dec 16, 2024
@dandavison
Send first_execution_run_id with Update requests
8b88fd9 
Fixes #682
dandavison added a commit that referenced this issue Dec 16, 2024
@dandavison
Send first_execution_run_id with Update requests
e8f59a7 
Fixes #682
dandavison added a commit that referenced this issue Dec 16, 2024
@dandavison
Send first_execution_run_id with Update requests
193c4ab 
Fixes #682
dandavison added a commit that referenced this issue Dec 19, 2024
@dandavison
Send first_execution_run_id with Update requests
c0b06b1 
Fixes #682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dandavison