Linux ARM and Python 3.11 Support #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c3bb11 to
40e07c1
Compare
| @@ -16,8 +16,8 @@ | |||
|
|
|||
|
|
|||
| def test_workflow_sandbox_stdlib_module_names(): | |||
| if sys.version_info != (3, 10): | |||
| pytest.skip("Test only runs on 3.10") | |||
| if sys.version_info[1] != 11: | |||
There was a problem hiding this comment.
Why aren't we checking the major version info anymore?
There was a problem hiding this comment.
I was improperly checking it (the tuple is actually like 5 values, so my != wasn't doing the right thing anyways, even though > and < and the like do). Since we are never expected to be off version 3 anyways, this was simpler than manually destructuring.
Quinn-With-Two-Ns
approved these changes
Oct 31, 2022
Sushisource
approved these changes
Oct 31, 2022
bergundy
reviewed
Oct 31, 2022
| # Need the 8 CPU version that has 12GB of RAM, the 4 CPU version | ||
| # only has 6 GB. | ||
| runsOn: buildjet-8vcpu-ubuntu-2204-arm | ||
| runs-on: ${{ matrix.runsOn || matrix.os }} |
There was a problem hiding this comment.
Why do you need runsOn and os? Could just use runsOn
There was a problem hiding this comment.
Because having os consistent in the matrix makes the job list look pretty in the UI :-)
bergundy
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Checklist